fix(TVOS): navbar appearance customization #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alduzy
changed the title
kkafar
approved these changes
Jul 12, 2024
This was referenced Aug 23, 2024
This was referenced Aug 27, 2024
This was referenced Sep 24, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
## Description This PR intents to fix navigation bar appearance customization on tvOS. Now it's impossible to customize the navigation bar on tvOS. The options, such as `headerTintColor` are not applied at all and the defaults are making it hard to read when the appearance is set to `dark` on the device: - title text color defaults to white - backgroundColor of modal screens header defaults to dark gray In current implementation the appearance is set on the navigationItem, like this: `navigationItem.standardAppearance = appearance`. Out of curiosity I tried setting the appearance on navigationBar as found in [this article](https://developer.apple.com/documentation/uikit/uinavigationcontroller/customizing_your_app_s_navigation_bar?language=objc), like this: `navigationBar.standardAppearance = appearance` and I got following error: `New Bar Appearance API is not supported on this version of tvOS. Use legacy customization`. Looks like the `UINavigationBarAppearance` does not work for us although it should be fine on tvOS 13+ according to the [docs](https://developer.apple.com/documentation/uikit/uinavigationbarappearance?language=objc). I found using the [legacy customizations](https://developer.apple.com/documentation/uikit/uinavigationbar/legacy_customizations?language=objc) to be the only working solution. Fixes software-mansion#2222 ## Changes - updating appearance manually for tvOS ## Screenshots / GIFs | `before` | `after` | |--------|--------| |  |  | |  |  | ## Test code and steps to reproduce - Use the `TVOSExample` - Toggle light/dark appearance on the device - Customize header options, such as `headerTintColor` ## Checklist - [x] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intents to fix navigation bar appearance customization on tvOS.
Now it's impossible to customize the navigation bar on tvOS. The options, such as
headerTintColorare not applied at all and the defaults are making it hard to read when the appearance is set todarkon the device:In current implementation the appearance is set on the navigationItem, like this:
navigationItem.standardAppearance = appearance. Out of curiosity I tried setting the appearance on navigationBar as found in this article, like this:navigationBar.standardAppearance = appearanceand I got following error:New Bar Appearance API is not supported on this version of tvOS. Use legacy customization.Looks like the
UINavigationBarAppearancedoes not work for us although it should be fine on tvOS 13+ according to the docs. I found using the legacy customizations to be the only working solution.Fixes #2222
Changes
Screenshots / GIFs
beforeafterTest code and steps to reproduce
TVOSExampleheaderTintColorChecklist